Data providers ♥ are a super convenient feature to run the same tests with multiple sets of data. I use them quite heavily on a day to day basis in my automated tests and it helps me to write code that adheres to the DRY principle quite easily.
I wrote a post on understanding how to use Data providers in TestNG with Kotlin some time back. You can check it out here
The case for setup and teardowns via @Before and @After
Another useful feature and common pattern while writing clean tests with TestNG is the use of
@After annotations at different levels (method, class, suite, etc)
They afford us a couple of unique conveniences and are a sensible pattern to follow:
- Before annotated functions always run before the test/group of tests and if any failure occurs in this section then it is reported as a warning in setup code and not the test method
- They allow cleaner separation of pre and post-condition logic from the actual test code allowing better readability
- Methods annotated with After always run even if some assertion fails in the test code, Allowing you to gracefully reset any temporary data that might have been created or god forbid modified by a test
@Before and @After annotations with @Dataprovider
However what if I want to do both setup/teardown for the test based on the data in the data provider combination?
How do we test this behavior?
Let’s come back to our test cases.
We would want to check that a booking can be made successfully for a vehicle type.
Below is a test for the same, We make a booking and then check if the booking exists in the system with simple assertions.
Now, this is all fine, but what if we want to test the same flow for multiple different vehicle types? For instance, in this case, Car and Car XL vehicle types.
Surely you can copy the same test and replace the vehicle type with Car right?
Well, it would just lead to a maintenance nightmare later on with all the duplicated code.
By eliminating the duplicates, you ensure that the code says everything once and only once, which is the essence of good design.
— Fowler, Martin. Refactoring (Addison-Wesley Object Technology Series) (pp. 55-56). Pearson Education. Kindle Edition.
Data providers to the rescue
We could instead use data providers to run the same test with different data. Here is how that would look like.
If we run the test then it would work fine.
However, we already knew that data providers are awesome and can be used from this previous post
Let’s expand the problem:
Now that the booking creation test looks fine. What if we want to test the cancellation flow? i.e.
As a user I should be able to cancel the created booking
Let’s add a test for the cancel flow:
The test follows below flow:
- Make a booking
- Check if the booking is made
- Cancel the booking
- Check booking is canceled
Now to show, what do most of us immediately tend to do in situations like this?
I copied the code from booking creation and then added the code for the cancellation flow.
While this works, this certainly violates the DRY principle. We have the same code in two different test methods and added a bunch of more problems for ourselves.
- What if there is a change in the Booking class? We would now have to make the same change in multiple places.
- Also, the test methods’ size has just gone up to 15 LOC. While this is manageable now. It can quickly turn bad if we do this 10, 20 or 50 times. After that welcome to 2 hours of debugging every morning when something fails and heaven forbid if you have to update these tests.
Using setup/teardown blocks
If you notice, both the test methods need the booking to be created as a pre-requisite right?
Let’s refactor these methods to make use of Setup
@Beforefeature of TestNG
Here are the changes I have made:
- I created a givenBookingIsCreated method annotated with @BeforeMethod so that it runs for all the tests
- Extracted orderId as a class level property which would be initialized by the setup method (Line 2)
- Removed the booking creation related code from the test methods
Side note. I realized that you cannot specify a Kotlin primitive (Int) as lateinit and thus I refactored the booking class to have the orderId of type String
The code looks much better now. Let’s run it.
In typical developer fashion. The code rarely works the first time. 🙂 Plus we were able to bomb all our tests!
Let’s take a look at the exception:
Can inject only one of <ITestContext, XmlTest, Method, Object, ITestResult> into a @BeforeMethod annotated givenBookingIsCreated.
For more information on native dependency injection please refer to http://testng.org/doc/documentation-main.html#native-dependency-injection
TestNG is such a kind framework to give us all the details that we need to fix this. It mentions that we can only have certain types of dependencies injected into the @BeforeMethod which are <ITestContext, XmlTest, Method, Object, ITestResult>
Lets back up a bit.
- Our original requirement was that we want to set up different types of bookings such that the booking and cancellation test can verify that those flows are working fine
- We want to use data providers so that we don’t have to write the same test for different sets of data.
Turns out the culprit very rightly is that we thought we could pass around any parameters used in the test method to before method as well.
fun givenBookingIsCreated(vehicleType: VehicleType)
Let’s fix this:
I have replaced the parameter with an Object which can be represented as
Let’s run the tests again:
This is what I was looking for. All tests passed. Time for some well-deserved coffee.
- With following this approach of combining Before/After annotations with Data provider values, we can keep our test method code leaner
- TestNG Dependency injection is quite powerful and used correctly gives your amazing powers. Read more about it here
- Do not repeat yourself while coding, please! 😉
- You can find the complete Gist with the latest code here
Hopefully, this long-winded story about TestNG data providers and setup methods gave you something valuable to take away. I recently faced this problem at work and could find this solution.
Are there better ways to solve this? Let me know in the comments and if you found this useful, Do share with a friend or colleague. Until next time! Cheers!